Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Currently, each commit is triggering a vaccine workflow run in GitLab. However, where are some caveats:
Hence, the validation is included into our decision to whether a pull request can be merged.
What does this PR do?
I am improving our cross CI system by implementing a polling model to report workflow status.
This is far from ideal, but at least we get a signal from vaccine for each pull request. Current limitations of polling approach:
In the future, instead of having a disconnected workflow, we can make the vaccine workflow report its status back to the original PR in
Datadog/dd-trace-rb
and configure GitHub required status check to includevaccine
. However, such approach requireschecks:write
permission with an integrated Github App, that takes me time to go through the organization to setup.Change log entry
None.