Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polling vaccine #4286

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Polling vaccine #4286

merged 2 commits into from
Jan 14, 2025

Conversation

TonyCTHsu
Copy link
Contributor

Motivation:

Currently, each commit is triggering a vaccine workflow run in GitLab. However, where are some caveats:

  • When token is invalid, the 403 response does not failed the Gitlab job.
  • Gitlab job does not acknowledge vaccine workflow failure.

Hence, the validation is included into our decision to whether a pull request can be merged.

What does this PR do?

I am improving our cross CI system by implementing a polling model to report workflow status.

This is far from ideal, but at least we get a signal from vaccine for each pull request. Current limitations of polling approach:

  • Resource intensive (constant API calls)
  • Potential rate limiting issues
  • High latency in status updates
  • Maintenance overhead
  • Difficulty in handling errors or retries
  • No built-in audit trail

In the future, instead of having a disconnected workflow, we can make the vaccine workflow report its status back to the original PR in Datadog/dd-trace-rb and configure GitHub required status check to include vaccine. However, such approach requires checks:write permission with an integrated Github App, that takes me time to go through the organization to setup.

Change log entry
None.

@TonyCTHsu TonyCTHsu requested a review from a team as a code owner January 14, 2025 12:48
@TonyCTHsu TonyCTHsu added the dev/testing Involves testing processes (e.g. RSpec) label Jan 14, 2025
@TonyCTHsu TonyCTHsu merged commit 6dc5d1a into master Jan 14, 2025
383 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/vaccine-polling branch January 14, 2025 13:07
@github-actions github-actions bot added this to the 2.9.0 milestone Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants