[NO-TICKET] Disable flaky barrier spec #4275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?** This PR disables a spec that's been flaky for a very long time (see DataDog/ruby-guild#191, but I suspect I saw it back in DataDog/ruby-guild#50 (comment) ) and it just failed on me again: https://github.com/DataDog/dd-trace-rb/actions/runs/12706052002/job/35418238631?pr=4234 I'm not sure this test is getting us a lot of value, so let's stop the flaky impact until we can dedicate time to fixing it. (Maybe @lloeki can help here as the original author of the class and tests?) **Motivation:** Get to zero flaky tests in our codebase! **Additional Notes:** N/A **How to test the change?** Validate spec is now skipped.
Datadog ReportBranch report: ✅ 0 Failed, 22119 Passed, 1476 Skipped, 5m 31.51s Total Time |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4275 +/- ##
==========================================
- Coverage 97.72% 97.71% -0.02%
==========================================
Files 1354 1354
Lines 82450 82450
Branches 4236 4236
==========================================
- Hits 80578 80566 -12
- Misses 1872 1884 +12 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2025-01-10 09:20:39 Comparing candidate commit f66f48a in PR branch Found 2 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics. scenario:line instrumentation - targeted
scenario:method instrumentation
|
TonyCTHsu
approved these changes
Jan 10, 2025
TonyCTHsu
reviewed
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR disables a spec that's been flaky for a very long time (see https://github.com/DataDog/ruby-guild/issues/191, but I suspect I saw it back in https://github.com/DataDog/ruby-guild/issues/50#issuecomment-1874210356 ) and it just failed on me again:
https://github.com/DataDog/dd-trace-rb/actions/runs/12706052002/job/35418238631?pr=4234
I'm not sure this test is getting us a lot of value, so let's stop the flaky impact until we can dedicate time to fixing it.
(Maybe @lloeki can help here as the original author of the class and tests?)
Motivation:
Get to zero flaky tests in our codebase!
Change log entry
None
Additional Notes:
N/A
How to test the change?
Validate spec is now skipped.