-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🤖] Update Supported Versions #4236
base: master
Are you sure you want to change the base?
Conversation
👋 Hey @DataDog/ruby-guild, please fill "Change log entry" section in the pull request description. If changes need to be present in CHANGELOG.md you can state it this way **Change log entry**
Yes. A brief summary to be placed into the CHANGELOG.md (possible answers Yes/Yep/Yeah) Or you can opt out like that **Change log entry**
None. (possible answers No/Nope/None) Visited at: 2025-01-28 20:27:19 UTC |
Datadog ReportBranch report: ❌ 1 Failed (0 Known Flaky), 22056 Passed, 1476 Skipped, 5m 47.39s Total Time ❌ Failed Tests (1)
|
BenchmarksBenchmark execution time: 2025-01-28 21:54:02 Comparing candidate commit b047cd3 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics. |
486ab51
to
392a80f
Compare
392a80f
to
68287a9
Compare
9ad6d48
to
5ce75ce
Compare
797133f
to
31fcc83
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4236 +/- ##
==========================================
+ Coverage 97.72% 97.73% +0.01%
==========================================
Files 1368 1368
Lines 82997 82997
Branches 4219 4219
==========================================
+ Hits 81105 81114 +9
+ Misses 1892 1883 -9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question on Net::HTTP
as I think the versions we're reporting are actually http.rb
e0bdd12
to
a29bf91
Compare
92419ea
to
475c6f5
Compare
Datadog ReportBranch report: ✅ 0 Failed, 22109 Passed, 1477 Skipped, 5m 59.27s Total Time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both of the added files are unclear as to their contents, purpose and how they come to be:
gem_output.json
provides no hints/explanation as to what it contains or where it came from.
The markdown file, if it's meant for consumption by humans, I think should have some prose in it describing its contents. If it's not meant for consumption by humans, perhaps it should be in some other format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both of the added files are unclear as to their contents, purpose and how they come to be:
gem_output.json
provides no hints/explanation as to what it contains or where it came from.
The markdown file, if it's meant for consumption by humans, I think should have some prose in it describing its contents. If it's not meant for consumption by humans, perhaps it should be in some other format.
integration_versions.md
Outdated
@@ -0,0 +1,54 @@ | |||
# Integrations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a markdown comment to the top of the file saying it was generated from .github/scripts/generate_table_versions.rb
?
@p-datadog thanks!
The markdown file is definitely meant for human consumption. What other format would work better? Note that at the end of the quarter these will be sourced onto the public documentation replacing this table: https://docs.datadoghq.com/tracing/trace_collection/compatibility/ruby#integrations Note that we will still need to (likely hard code) the configuration options over. @quinna-h could we add a sentence at the top:
|
194de96
to
726fe31
Compare
726fe31
to
b047cd3
Compare
The public docs page https://docs.datadoghq.com/tracing/trace_collection/compatibility/ruby/ is sourced from https://github.com/DataDog/dd-trace-rb/blob/fe9272b14743e9af065f71cd9ef71181f1086d89/docs/Compatibility.md. dd-trace-rb/docs/Compatibility.md Line 64 in fe9272b
For example, we can rename ## Integrations
- For a list of available integrations, and their configuration options, refer to the following:
+ [GENERATED_INTEGRATION_VERSIONS_PLACEHOLDER]
- ... The GitHub action you wrote would then render the real |
b047cd3
to
1faa836
Compare
This is a PR to update the table for supported integration versions.
The supported versions markdown is generated from the minimum and maximum tested versions of each integration,
as defined from the
gemfile.lock
gem declarations.Workflow run: Generate Supported Versions
This should be tied to tracer releases, or triggered manually.