Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No requirement for benchmarks #4186

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

TonyCTHsu
Copy link
Contributor

Motivation:
Our Gitlab pipeline is basically namespaced with stages.

However, this means the benchmark job requires previous stages to finish and runs last. The job itself took plenty of time (around 20 min) before it could add a PR comment.

However, those stages are not dependent on each other and should run in parallel

What does this PR do?

Make the job without requirement.

@TonyCTHsu TonyCTHsu requested a review from a team as a code owner December 3, 2024 14:09
@TonyCTHsu TonyCTHsu added the dev/ci Involves CircleCI, GitHub Actions, or GitLab label Dec 3, 2024
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Dec 3, 2024

Datadog Report

Branch report: tonycthsu/benchmarks-no-requirement
Commit report: 0cf25e0
Test service: dd-trace-rb

✅ 0 Failed, 22040 Passed, 1459 Skipped, 5m 28.46s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Dec 3, 2024

Benchmarks

Benchmark execution time: 2024-12-03 14:32:00

Comparing candidate commit 0cf25e0 in PR branch tonycthsu/benchmarks-no-requirement with baseline commit 8ec90f0 in branch master.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics.

scenario:line instrumentation - targeted

  • 🟩 throughput [+11765.860op/s; +12388.463op/s] or [+7.641%; +8.045%]

scenario:method instrumentation

  • 🟩 throughput [+10729.030op/s; +11357.037op/s] or [+6.472%; +6.851%]

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.76%. Comparing base (5705775) to head (0cf25e0).
Report is 18 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4186      +/-   ##
==========================================
+ Coverage   97.75%   97.76%   +0.01%     
==========================================
  Files        1357     1357              
  Lines       81890    81891       +1     
  Branches     4164     4164              
==========================================
+ Hits        80050    80064      +14     
+ Misses       1840     1827      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@y9v y9v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 awesome!

@TonyCTHsu TonyCTHsu merged commit 7f079c9 into master Dec 3, 2024
161 of 183 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/benchmarks-no-requirement branch December 3, 2024 14:37
@github-actions github-actions bot added this to the 2.8.0 milestone Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/ci Involves CircleCI, GitHub Actions, or GitLab
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants