DEBUG-2334 add new_record flag to ActiveRecord model custom serializer #4165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Dynamic Instrumentation ships with a custom serializer for ActiveRecord models which lifts the interesting fields (i.e. attributes) to the top level of the serialized object.
This PR adds the new_record? flag to the serialized object.
Motivation:
The current rendering of AR models in dynamic instrumentation UI is somewhat "weird" because the attributes are nested under the "attributes" field, but there are no other fields. It's confusing why the attributes aren't just rendered on the top level.
Adding the new_record flag, in my opinion, improves the UI to where it looks more polished and doesn't look like something is wrong with it.
Change log entry
None (part of initial DI release)
Additional Notes:
How to test the change?
Unit tests are included