Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gemspec dependencies #4152

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Update gemspec dependencies #4152

merged 3 commits into from
Nov 25, 2024

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Nov 22, 2024

Motivation:

Leverage our scheduled job to update gemspec specific dependencies such as msgapck

What does this PR do?

  1. Add a rake task edge:gemspec to update gemspec specific dependencies to all gemfiles belongs to current runtime
  2. Introduce edge:gemspec into our schedule automation
  3. Remove obsolete ffi constraint for Ruby 3.4 and validate the task implementation

@TonyCTHsu TonyCTHsu requested a review from a team as a code owner November 22, 2024 22:40
@pr-commenter
Copy link

pr-commenter bot commented Nov 22, 2024

Benchmarks

Benchmark execution time: 2024-11-25 12:30:15

Comparing candidate commit 8130596 in PR branch tonycthsu/update-deps with baseline commit e52a675 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.78%. Comparing base (91de22d) to head (4dec6f0).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4152      +/-   ##
==========================================
- Coverage   97.79%   97.78%   -0.01%     
==========================================
  Files        1350     1350              
  Lines       81327    81327              
  Branches     4107     4107              
==========================================
- Hits        79530    79525       -5     
- Misses       1797     1802       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/update-deps branch from 093141c to 8130596 Compare November 25, 2024 11:49
@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/update-deps branch from 8130596 to 4dec6f0 Compare November 25, 2024 13:42
@TonyCTHsu TonyCTHsu merged commit 7f72e43 into master Nov 25, 2024
293 of 294 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/update-deps branch November 25, 2024 14:05
@TonyCTHsu TonyCTHsu added the dev/internal Other internal work that does not need to be included in the changelog label Nov 25, 2024
@github-actions github-actions bot added this to the 2.8.0 milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/internal Other internal work that does not need to be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants