Add config support for "on_error" in Elasticsearch tracing #4066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mirrors the functionality that is already present in many other instrumenters. Reasons for wanting this: You might want to ignore some errors in some expected scenarios such as Elasticsearch::Transport::Transport::Errors::NotFound or Elasticsearch::Transport::Transport::Errors::Conflict
9398422 to
4e02912
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4066 +/- ##
==========================================
+ Coverage 97.77% 97.78% +0.01%
==========================================
Files 1353 1353
Lines 81785 81806 +21
Branches 4141 4143 +2
==========================================
+ Hits 79963 79997 +34
+ Misses 1822 1809 -13 ☔ View full report in Codecov by Sentry. |
rtrieu
approved these changes
Nov 6, 2024
marcotc
approved these changes
Nov 25, 2024
Strech
approved these changes
Nov 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors the functionality that is already present in many other instrumenters.
Reasons for wanting this:
One might want to ignore some errors in some expected scenarios such as
Elasticsearch::Transport::Transport::Errors::NotFoundor
Elasticsearch::Transport::Transport::Errors::ConflictWhat does this PR do?
Adds
on_errorconfiguration support for Elasticsearch tracing and forwards it toTracing.traceMotivation:
We have flows where
NotFoundexceptions are expected and we make sure to handle them in the application.We don't want them to show up as errors in the dashboard though.
Change log entry
Yes. Add configuration option
on_errorto Elasticsearch tracing(Added by @Strech)
How to test the change?
Run provided tests with
bundle exec rake test:elasticsearch