[NO-TICKET] Bump debase-ruby_core_source dependency to 3.3.6 #3988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?** This PR bumps our dependency on debase-ruby_core_source to version 3.3.6. This version includes the headers for the Ruby 3.3.5 as well as 3.4.0-preview2; up until now we were supporting those Ruby versions using the 3.3.0 headers. **Motivation:** Use up-to-date headers for profiling on Ruby 3.3.5 and 3.4.0-preview2. **Additional Notes:** I've updated the appraisal gemfiles as well. **How to test the change?** Validate that CI is green.
BenchmarksBenchmark execution time: 2024-10-10 14:07:15 Comparing candidate commit 6b10722 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 23 metrics, 2 unstable metrics. |
marcotc
approved these changes
Oct 15, 2024
|
Update: This PR is blocked because we're very close to the internal budget for some of the Ruby packaged releases, and this makes us go over the limit. The team is discussing next steps on this issue. |
|
Obsolete: #4014 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR bumps our dependency on debase-ruby_core_source to version 3.3.6. This version includes the headers for the Ruby 3.3.5 as well as 3.4.0-preview2; up until now we were supporting those Ruby versions using the 3.3.0 headers.
Motivation:
Use up-to-date headers for profiling on Ruby 3.3.5 and 3.4.0-preview2.
Additional Notes:
I've updated the appraisal gemfiles as well.
How to test the change?
Validate that CI is green.