Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delay sampling decision to allow sampling on tags and resource #3956

Merged
merged 38 commits into from
Oct 7, 2024
Merged
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
0f3ff3e
sample on all trace and root span tags
ZStriker19 Sep 24, 2024
09b7afd
sample before digest
ZStriker19 Sep 25, 2024
10af562
only sample if sampling decision not already made
ZStriker19 Sep 25, 2024
5f280bd
linting
ZStriker19 Sep 25, 2024
7203b51
sample trace before flush unless already sampled
ZStriker19 Sep 25, 2024
7f4dceb
change conditional
ZStriker19 Sep 25, 2024
f216d22
remove sampling at span start
ZStriker19 Sep 25, 2024
e9b2cd7
update trace operation to take tracer for sampling
ZStriker19 Sep 25, 2024
093d8c5
Merge branch 'zachg/fix_sample_on_all_root_span_tags' into zachg/lazy…
ZStriker19 Sep 25, 2024
d76927c
Merge branch 'zachg/sample_before_digest' into zachg/lazy_sampling
ZStriker19 Sep 25, 2024
63189ea
Merge branch 'zachg/sample_before_trace_flush' into zachg/lazy_sampling
ZStriker19 Sep 25, 2024
630e6f2
check sampling priority differently
ZStriker19 Sep 25, 2024
a4d4615
Merge branch 'zachg/remove_sampling_at_span_start' into zachg/lazy_sa…
ZStriker19 Sep 25, 2024
e6e38f0
fix get_metric
ZStriker19 Sep 25, 2024
83b24f3
change to checking sampling_priority before running sample
ZStriker19 Sep 30, 2024
60b9e09
integration tests for sampling with tag and resource combinations
ZStriker19 Sep 30, 2024
fac3d5d
broken trace_operation_spec test
ZStriker19 Oct 2, 2024
fab63c7
fix how we call tracer in trace operation
ZStriker19 Oct 2, 2024
097cebc
Merge branch 'master' into zachg/lazy_sampling
ZStriker19 Oct 3, 2024
bba15ec
handle non-integer float edge case
ZStriker19 Oct 3, 2024
6d42bf8
Merge branch 'zachg/lazy_sampling' of github.com:DataDog/dd-trace-rb …
ZStriker19 Oct 3, 2024
5f4c58a
handle non-integer float edge case
ZStriker19 Oct 3, 2024
9b3729d
fix tracer_spec tests since sampling happens at end
ZStriker19 Oct 3, 2024
424b9b5
add edge case test for non zero decimal matching
ZStriker19 Oct 3, 2024
9390ccc
test
ZStriker19 Oct 3, 2024
140355a
it works
ZStriker19 Oct 3, 2024
7c483e4
* is the same as infinite *
ZStriker19 Oct 3, 2024
8b202b0
Merge branch 'master' into zachg/lazy_sampling
ZStriker19 Oct 3, 2024
edf5c2f
* is the same as infinite * edge case test
ZStriker19 Oct 4, 2024
34457d4
another test for matching float w/ zero decimal
ZStriker19 Oct 4, 2024
bf51dd1
Merge branch 'master' into zachg/lazy_sampling
ZStriker19 Oct 4, 2024
bd41d98
tags test broken
ZStriker19 Oct 5, 2024
469a92b
fix tags test if meta is allowed in tags
ZStriker19 Oct 5, 2024
ee8ddd8
Merge branch 'master' into zachg/lazy_sampling
ZStriker19 Oct 7, 2024
5648a4f
trace operation tag takes precedence over root span tag
ZStriker19 Oct 7, 2024
aca9e02
Merge branch 'zachg/lazy_sampling' of github.com:DataDog/dd-trace-rb …
ZStriker19 Oct 7, 2024
f5f824b
test metrics
ZStriker19 Oct 7, 2024
bc81964
Merge branch 'master' into zachg/lazy_sampling
ZStriker19 Oct 7, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
* is the same as infinite * edge case test
  • Loading branch information
ZStriker19 committed Oct 4, 2024
commit edf5c2f287886df49a49960ef669f086522b1699
7 changes: 7 additions & 0 deletions spec/datadog/tracing/sampling/matcher_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,13 @@

it { is_expected.to eq(true) }
end

context 'when multiple *s are used' do
let(:trace_service) { 'hello_service' }
let(:service) { '***' }

it { is_expected.to eq(true) }
end
end

context 'with a resource matcher' do
Expand Down
Loading