DEBUG-2334 Dynamic Instrumentation Redactor component #3901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd79ae4 to
45d7fe6
Compare
BenchmarksBenchmark execution time: 2024-09-10 20:37:45 Comparing candidate commit 127a2e2 in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 21 metrics, 2 unstable metrics. scenario:profiler - hold / resume
scenario:profiler - sample timeline=false
|
This component determines whether a variable, attribute or hash element should be redacted based on the identifier name/key name and the type of the value. Unit tests are included. The Redactor component technically depends on DI settings but they are mocked out in the unit tests.
45d7fe6 to
f25e6f1
Compare
|
Test cases checked against DataDog/libdatadog#497. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3901 +/- ##
========================================
Coverage 97.86% 97.87%
========================================
Files 1279 1281 +2
Lines 76520 76620 +100
Branches 3747 3753 +6
========================================
+ Hits 74890 74992 +102
+ Misses 1630 1628 -2 ☔ View full report in Codecov by Sentry. |
anmarchenko
approved these changes
Sep 11, 2024
TonyCTHsu
approved these changes
Sep 11, 2024
y9v
approved these changes
Sep 11, 2024
y9v
pushed a commit
that referenced
this pull request
Sep 13, 2024
* Dynamic Instrumentation Redactor component This component determines whether a variable, attribute or hash element should be redacted based on the identifier name/key name and the type of the value. Unit tests are included. The Redactor component technically depends on DI settings but they are mocked out in the unit tests. * add non-ascii test cases * style --------- Co-authored-by: Oleg Pudeyev <code@olegp.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds Dynamic Instrumentation Redactor
This component determines whether a variable, attribute or hash element should be redacted based on the identifier name/key name and the type of the value.
Motivation:
Initial implementation of Dynamic Instrumentation for Ruby
Additional Notes:
The Redactor component technically depends on DI settings but they are mocked out in the unit tests.
How to test the change?
Unit tests are included.