-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[faraday] Add hostname to faraday annotation #387
[faraday] Add hostname to faraday annotation #387
Conversation
Thanks for the contribution @tinchi! I think this could be a good change, since you're right... The Without trying to expand the scope on this PR too much, I'm going to think on this a bit, so we know how this fits into making Faraday better. |
@delner by using only hostname i would get a better overview of how particular host behaves in terms of latency and error rate. because right now i only see only latency and error rate by request type: |
@tinchi Is that bottom screenshot something you photoshopped? (For sake of example?) |
@delner yeah just few tweaks in the chrome's dev console |
@tinchi Could we rebase this on |
@delner gonna do it shortly |
f87c11c
to
0b5daa3
Compare
This seems related to #277 since they are both concerned with assigning better |
Faraday integration is not very informative right now:
So i added hostname to the resource name