-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup docker compose #3854
Cleanup docker compose #3854
Conversation
@@ -28,7 +27,6 @@ services: | |||
TEST_OPENSEARCH_PORT: 9200 | |||
TEST_POSTGRES_HOST: postgres | |||
TEST_PRESTO_HOST: presto | |||
TEST_PRESTO_PORT: 8080 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this line be removed? The env var is still referenced here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be removed because it is provided by .env
file.
For each service, we are applying environment variables by providing env_file
and overwrite with environment.
For example:
env_file: ./.env
environment:
- ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! I missed the .env
file
BenchmarksBenchmark execution time: 2024-08-21 11:58:15 Comparing candidate commit 7622101 in PR branch Found 0 performance improvements and 3 performance regressions! Performance is the same for 20 metrics, 2 unstable metrics. scenario:profiler - estimated profiler gc per minute (sample 60000 times + serialize result)
scenario:profiler - profiler gc
scenario:profiler - sample timeline=false
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3854 +/- ##
==========================================
+ Coverage 97.83% 97.86% +0.02%
==========================================
Files 1264 1269 +5
Lines 75725 75868 +143
Branches 3729 3736 +7
==========================================
+ Hits 74084 74245 +161
+ Misses 1641 1623 -18 ☔ View full report in Codecov by Sentry. |
What does this PR do?
TEST_PRESTO_HOST
from.env
to use127.0.0.1
common-environment-3x
anchor (They are identical tocommon-environment
, exceptpresto
host which is fixed from.env
)common-depends-on
anchorversion
field fromdocker-compose.yml
Why
I stumble on this overwriting complexity (with layers of overwriting environment) when testing with telemetry.