[PROF-10099] Upgrade to libdatadog 10 #3753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?** This PR upgrades the datadog gem to use libdatadog 10. There was a tiny breaking API change, but otherwise it's a drop-in upgrade. **Motivation:** There were a few improvements to crash tracking that I'd like to pick up (some of the features need to be configured -- I'll open a separate PR for it). Also, staying on the latest libdatadog enables us to pick up the latest improvements and also makes it easier to develop new features that need libdatadog changes. **Additional Notes:** As usual, I'm opening this PR as a draft as libdatadog 10 is not yet available on rubygems.org, and I'll come back to re-trigger CI and mark this as non-draft once it is. **How to test the change?** Our existing test coverage includes libdatadog testing, so a green CI is good here :)
ivoanjo
added a commit
to DataDog/libdatadog
that referenced
this pull request
Jul 3, 2024
**What does this PR do?** This PR includes the changes documented in the "Releasing a new version to rubygems.org" part of the README: https://github.com/datadog/libdatadog/tree/main/ruby#releasing-a-new-version-to-rubygemsorg (It's also very similar to the v9.0.0 release PR). **Motivation:** Enable Ruby to use libdatadog v10.0.0. **Additional Notes:** N/A **How to test the change?** I've tested this release locally using the changes in DataDog/dd-trace-rb#3753 . As a reminder, new libdatadog releases don't get automatically picked up by dd-trace-rb, so the PR that bumps the Ruby profiler will also test this release against all supported Ruby versions.
ivoanjo
added a commit
to DataDog/libdatadog
that referenced
this pull request
Jul 3, 2024
**What does this PR do?** This PR includes the changes documented in the "Releasing a new version to rubygems.org" part of the README: https://github.com/datadog/libdatadog/tree/main/ruby#releasing-a-new-version-to-rubygemsorg (It's also very similar to the v9.0.0 release PR). **Motivation:** Enable Ruby to use libdatadog v10.0.0. **Additional Notes:** N/A **How to test the change?** I've tested this release locally using the changes in DataDog/dd-trace-rb#3753 . As a reminder, new libdatadog releases don't get automatically picked up by dd-trace-rb, so the PR that bumps the Ruby profiler will also test this release against all supported Ruby versions.
1acdb71 to
b7ecd26
Compare
anmarchenko
approved these changes
Jul 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3753 +/- ##
=======================================
Coverage 97.90% 97.90%
=======================================
Files 1237 1237
Lines 74200 74200
Branches 3598 3598
=======================================
Hits 72644 72644
Misses 1556 1556 ☔ View full report in Codecov by Sentry. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR upgrades the datadog gem to use libdatadog 10.
There was a tiny breaking API change, but otherwise it's a drop-in upgrade.
Motivation:
There were a few improvements to crash tracking that I'd like to pick up (some of the features need to be configured -- I'll open a separate PR for it).
Also, staying on the latest libdatadog enables us to pick up the latest improvements and also makes it easier to develop new features that need libdatadog changes.
Additional Notes:
As usual, I'm opening this PR as a draft as libdatadog 10 is not yet available on rubygems.org, and I'll come back to re-trigger CI and mark this as non-draft once it is.
How to test the change?
Our existing test coverage includes libdatadog testing, so a green CI is good here :)