Return empty log correlation when tracing is disabled #3731
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you completely disabled tracing, you will see no spans in the Datadog app, but your logs will still look like this:
This information pollutes the logs, it is useless without tracing enabled.
In particular, it is common to disable tracing in development environments. This issue makes logs in such environments much less developer friendly.
This PR returns a fallback empty String for
log_correlation
when tracing is disabled.Because the contract of the method is that it always returns a String, it is not an option to return
nil
without making it a breaking change. Also, an empty String concatenation should be harmless to log entries.