Add ability to set sampling rules by resource #3513
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3513 +/- ##
========================================
Coverage 98.23% 98.24%
========================================
Files 1275 1275
Lines 75226 75369 +143
Branches 3552 3558 +6
========================================
+ Hits 73901 74045 +144
+ Misses 1325 1324 -1 ☔ View full report in Codecov by Sentry. |
|
👋 @cjubb39, thank you so much for this request. We are also working on this feature ourselves, and your PR looks like a great contribution to get this work delivered. Will touch base soon about this feature. |
|
@marcotc great to hear it's being prioritized! The feature would be quite useful at my company -- so please let me know if there's any massaging I can do to this PR to help speed things along! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support for sampling based on resources. It does not change anything about when the rules / matchers / etc are evaluated. It just compares against the existing
resourcevalue in addition to thenameandservicevalues.Default behavior continues to be matching all resources
Motivation:
I was looking for a way to ensure that everything from a given resource within a service was sampled at a
1.0rate. I also noticed this feature existed in the python interface (added here) so it seemed there would be no fundamental objection.Additional Notes:
How to test the change?
Mirrored the existing testing for
nameandservice. Additionally added in test cases for the combinations of(name,service,resource)patterns.For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!