Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check workflow branches #3415

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Fix check workflow branches #3415

merged 1 commit into from
Jan 29, 2024

Conversation

lloeki
Copy link
Member

@lloeki lloeki commented Jan 29, 2024

2.0 Upgrade Guide notes

What does this PR do?

Always run checks.

Motivation:

The workflow fails to run for PRs targeting 2.0, and x.y-stable branches. It should always run instead.

Additional Notes:

They're cheap enough. "Always" sounds like a good plan.

How to test the change?

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

The workflow fails to run for PRs targeting 2.0, and x.y-stable
branches. It should always run instead.
@lloeki lloeki requested a review from a team as a code owner January 29, 2024 12:25
@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Jan 29, 2024
@lloeki lloeki mentioned this pull request Jan 29, 2024
2 tasks
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@lloeki lloeki merged commit e8b75dd into master Jan 29, 2024
220 checks passed
@lloeki lloeki deleted the fix-check-workflow-branches branch January 29, 2024 13:45
@github-actions github-actions bot added this to the 1.20.0 milestone Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/github Github repository maintenance and automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants