[NO-TICKET] Minor: Print core dump status info even when already enabled #3305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?** This PR tweaks the `enable_core_dumps` helper to also print the code dump status (maximum size and output pattern) even when core dumps are already enabled. This will allow us to know where to find the core dump files in such situations. **Motivation:** Simplify diagnostics when using this helper. **Additional Notes:** N/A **How to test the change?** This class already has test coverage. To quickly test it manually, running `load '.../enable_core_dumps.rb'` more than once will trigger the multiple messages.
marcotc
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR tweaks the
enable_core_dumpshelper to also print the code dump status (maximum size and output pattern) even when core dumps are already enabled. This will allow us to know where to find the core dump files in such situations.Motivation:
Simplify diagnostics when using this helper.
Additional Notes:
N/A
How to test the change?
This class already has test coverage. To quickly test it manually, running
load '.../enable_core_dumps.rb'more than once will trigger the multiple messages.For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.