Allow RateSampler with a sampling rate of zero #3295
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.0 Upgrade Guide notes
The custom sampler class
Datadog::Tracing::Sampling::RateSampler
now accepts asample_rate
of zero. This will drop all spans. Before 2.0, theRateSampler
would fall back to a sample rate of1.0
when provided with asample_rate
of zero.Motivation:
This PR creates consistency across all sampling configurations: they all allowed a zero sampling rate, only
RateSampler
was the exception.Additional Notes:
How to test the change?
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!