Revert "Disable Ruby 3.3 integration due to protobuf compilation error" #3285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?** This reverts commit f9ebce9. **Motivation:** In #3211 we disabled our CI integration testing on Ruby 3.3 because one of the dependencies (protobuf) had an incompatibility at the time (see protocolbuffers/protobuf#14509 for details). Upstream has since fixed the issue, so we're good to go. **Additional Notes:** N/A **How to test the change?** Check that CircleCI is now also running the `build_and_test_integration-3.3` test.
marcotc
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This reverts commit f9ebce9.
Motivation:
In #3211 we disabled our CI integration testing on Ruby 3.3 because one of the dependencies (protobuf) had an incompatibility at the time (see protocolbuffers/protobuf#14509 for details).
Upstream has since fixed the issue, so we're good to go.
Additional Notes:
N/A
How to test the change?
Check that CircleCI is now also running the
build_and_test_integration-3.3test.For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.