[APPSEC-9343] Appsec support nested apps #2836
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix #2722
I tested the code against a local Rails app that mounts a Sinatra App.
The configuration on the Rails app looks like this:
To ensure we are not re-executing the request middleware code multiple times with the context of nested apps, we need to make sure we bail out at the proper time.
That removes the 🐛 that some customers are experiencing, which raises
Datadog::AppSec::Processor::AlreadyActiveContextError
Also, by making sure we continue the execution of the request without adding any extra calls to the WAF, we make sure to only calls the WAF the right amount of times 😄
Motivation
Additional Notes
I added a basic integration test to validate that things work as expected.
How to test the change?