-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Action: Add test for unstable Ruby VMs #1550
Conversation
I come back to actions/runner#2347 every so often and it just makes me sad that there's no support for it as described 😢. I guess we have not other way today, except completely hiding the output in case of error, but that's just GitHub actions I guess. |
Codecov Report
@@ Coverage Diff @@
## master #1550 +/- ##
==========================================
- Coverage 98.24% 98.23% -0.01%
==========================================
Files 878 878
Lines 42372 42372
==========================================
- Hits 41627 41626 -1
- Misses 745 746 +1
Continue to review full report at Codecov.
|
As documented in actions/runner#2347, the only way to get a green "total" CI outcome today, while allowing failures, is to add |
Meh indeed. I wonder how difficult it would be to post those outcomes as a GitHub comment, or as a slack message, something like "Hey, this is low priority/non-blocking but your PR failed to build on whatever-head". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This PR runs the latest, still unstable, version of CRuby, JRuby, and TruffleRuby against our existing test suite.
I used GitHub Actions instead of CircleCI because there's not easy way to get bleeding edge Ruby images in CircleCI, while the GitHub Action
ruby/setup-ruby
has great support for it out of the box.Luckily, they all the tests I could run pretty much pass, except for JRuby
ruby/setup-ruby
action being non-functional at this moment (not related toddtrace
). I've opened an issue description with the problem.There was only a single fix required for Ruby 3.1 support as of today.
I did not attempt to run tests that depended on external services (MySQL, Redis, MongoDB, etc.), and stuck to the ones that only depend on Ruby code.
I'll leave this PR in draft until the JRuby issue gets traction.