Tweak debug message about missing instrumentation #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A customer was a bit misled by seeing this message in their logs (e.g. it led them to believe CPU time profiling was not working). This debug message is still useful for our own debugging so I've left it, but I've reworded it to clarify that seeing this message is mostly harmless.
Codecov Report
@@ Coverage Diff @@
## master #1538 +/- ##
==========================================
- Coverage 98.23% 98.23% -0.01%
==========================================
Files 877 877
Lines 42269 42267 -2
==========================================
- Hits 41524 41522 -2
Misses 745 745
Continue to review full report at Codecov.
|
ericmustin
approved these changes
Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A customer was a bit misled by seeing this message in their logs (e.g. it led them to believe CPU time profiling was not working).
This debug message is still useful for our own debugging so I've left it, but I've reworded it to clarify that seeing this message is mostly harmless.