Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested error reporting not walking clause chain #1535

Merged
merged 2 commits into from
Jun 1, 2021
Merged

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented May 31, 2021

The implementation of nested error reporting in #1472 had a bug in which it did not correctly visit the full #cause error chain in the reported exception, only the first cause was reported.

This PR correctly navigate the whole cause chain and reports such information.

@marcotc marcotc added the bug Involves a bug label May 31, 2021
@marcotc marcotc self-assigned this May 31, 2021
@marcotc marcotc requested a review from a team May 31, 2021 21:58
@ivoanjo
Copy link
Member

ivoanjo commented Jun 1, 2021

Change looks good (was this my derp? ahaha oops I guess I optimized it a bit extra by removing part of the functionality), but the failures in both JRuby configurations seem to be deterministic.

Could you look into what's up with them?

@marcotc
Copy link
Member Author

marcotc commented Jun 1, 2021

@ivoanjo is was a simple JRuby test assertion failure, but it turned into a crash in CI 😮

@codecov-commenter
Copy link

Codecov Report

Merging #1535 (17db1f5) into master (b05fddf) will increase coverage by 0.00%.
The diff coverage is 92.85%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1535   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files         877      877           
  Lines       42261    42267    +6     
=======================================
+ Hits        41517    41523    +6     
  Misses        744      744           
Impacted Files Coverage Δ
spec/ddtrace/error_spec.rb 94.26% <91.66%> (+0.24%) ⬆️
lib/ddtrace/error.rb 97.72% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b05fddf...17db1f5. Read the comment docs.

@marcotc marcotc merged commit c3e56e0 into master Jun 1, 2021
@marcotc marcotc deleted the fix-error-nested branch June 1, 2021 23:25
@github-actions github-actions bot added this to the 0.50.0 milestone Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Involves a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants