Clean up singleton class eval statements #1529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like there's some issues with either the |
|
I fixed the |
Codecov Report
@@ Coverage Diff @@
## master #1529 +/- ##
=======================================
Coverage 98.23% 98.24%
=======================================
Files 877 877
Lines 42261 42253 -8
=======================================
- Hits 41517 41512 -5
+ Misses 744 741 -3
Continue to review full report at Codecov.
|
ivoanjo
approved these changes
Jun 1, 2021
| end | ||
| Rails::Application.singleton_class.class_eval do | ||
| def inherited(base) | ||
| # raise "You cannot have more than one Rails::Application" if Rails.application |
There was a problem hiding this comment.
Unrelated to this change, but this commented out line is a bit suspect 🤔 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite a few of our
class_evalandclass_eval + class << selfstatements were due to not having access the previously private #prepend or #include methods.This PR cleans up such usages.
Not all occurrences across the code base were converted, as some performed other operations (e.g. defining methods inside the
class << selfblock). This PR touches the ones that are safe to do so, with minimal refactor.Ruby 2.0 deprecation checklist