Lock gRPC version for older Rubies #1045
Merged
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcotc
commented
May 20, 2020
| @@ -501,6 +501,7 @@ elsif Gem::Version.new('2.3.0') <= Gem::Version.new(RUBY_VERSION) \ | |||
| gem 'grape' | |||
| gem 'graphql' | |||
| gem 'grpc' | |||
| gem 'google-protobuf', '~> 3.11.0' # Last version to support Ruby < 2.5 | |||
There was a problem hiding this comment.
We could lock grpc to a very old version, but instead we lock it's transitive dependency, google-protobuf, to the latest supported version, which is closer to what users using these older versions of Ruby are likely doing.
This allows for newer grpc installations, backed by an older, but compatible, google-protobuf.
delner
approved these changes
May 20, 2020
|
@delner, you are correct, it's only because of grpc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
google-protobuf3.12.0has been released, our older versions of Ruby have been trying to install it, but this new version only support Ruby => 2.5.Bundler/rubygems should know this and not try to install an compatible version, but that doesn't seem to be the case. I found a few older GH issues about this issue, but nothing conclusive.
I believe the older version of bundler+rubygems are likely part of the problem, but it's ok to use those old versions when testing older Rubies.
This PR locks gRPC and it's dependency,
google-protobuf, to the latest supported version for Ruby 2.2, 2.3 and 2.4. Ruby >= 2.5 continue to be supported by the latest release as usual.