Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(framework/pylons): pin github actions ubuntu runner to 20.04 #4619

Merged

Conversation

Yun-Kim
Copy link
Contributor

@Yun-Kim Yun-Kim commented Nov 23, 2022

Description

GitHub setup-python@v2 actions now fail to install Python 2.7 for our Pylons framework tests. This is because the ubuntu-latest runner (which is now ubuntu-22.04) does not support Python 2.7. This framework test setup action has been pinned to ubuntu-20.04 as this is the last version to support Python 2.7.

See upstream issue for more information.

Checklist

Motivation

Design

Testing strategy

Relevant issue(s)

Testing strategy

Reviewer Checklist

  • Title is accurate.
  • Description motivates each change.
  • No unnecessary changes were introduced in this PR.
  • Avoid breaking API changes unless absolutely necessary.
  • Tests provided or description of manual testing performed is included in the code or PR.
  • Release note has been added and follows the library release note guidelines, or else changelog/no-changelog label added.
  • All relevant GitHub issues are correctly linked.
  • Backports are identified and tagged with Mergifyio.

@Yun-Kim Yun-Kim added the changelog/no-changelog A changelog entry is not required for this PR. label Nov 23, 2022
@Yun-Kim Yun-Kim requested a review from a team as a code owner November 23, 2022 20:48
@mabdinur
Copy link
Contributor

@Mergifyio backport 0.61 1.6 1.5

@mergify
Copy link
Contributor

mergify bot commented Nov 23, 2022

@Kyle-Verhoog Kyle-Verhoog merged commit fdcefa9 into DataDog:1.x Nov 23, 2022
mergify bot pushed a commit that referenced this pull request Nov 23, 2022
…4619)

(cherry picked from commit fdcefa9)

# Conflicts:
#	.github/workflows/test_frameworks.yml
mergify bot pushed a commit that referenced this pull request Nov 23, 2022
mergify bot pushed a commit that referenced this pull request Nov 23, 2022
Kyle-Verhoog pushed a commit that referenced this pull request Nov 23, 2022
…4619) (#4621)

(cherry picked from commit fdcefa9)

Co-authored-by: Yun Kim <35776586+Yun-Kim@users.noreply.github.com>
Kyle-Verhoog pushed a commit that referenced this pull request Nov 23, 2022
…4619) (#4622)

(cherry picked from commit fdcefa9)

Co-authored-by: Yun Kim <35776586+Yun-Kim@users.noreply.github.com>
@Yun-Kim Yun-Kim deleted the yunkim/pin-pylons-framework-test-ubuntu branch November 24, 2022 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants