fix(ci): pin py-cpuinfo to 8.0.0 (backport #4375) #4379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description Our profiler and benchmark test suites currently use pytest-benchmark, which internally relies on a plugin import to `py-cpuinfo`, which has released a major version 9.x dropping support for Python <= 3.6. This has broken our profiler and benchmark test suites, so I've pinned those test suites to use `py-cpuinfo==8.0.0` which was the latest released version which still supports Python<=3.6. ## Checklist - [ ] Add additional sections for `feat` and `fix` pull requests. - [ ] [Library documentation](https://github.com/DataDog/dd-trace-py/tree/1.x/docs) and/or [Datadog's documentation site](https://github.com/DataDog/documentation/) is updated. Link to doc PR in description. ## Motivation ## Design ## Testing strategy ## Relevant issue(s) ## Testing strategy ## Reviewer Checklist - [ ] Title is accurate. - [ ] Description motivates each change. - [ ] No unnecessary changes were introduced in this PR. - [ ] Avoid breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [ ] Tests provided or description of manual testing performed is included in the code or PR. - [ ] Release note has been added for fixes and features, or else `changelog/no-changelog` label added. - [ ] All relevant GitHub issues are correctly linked. - [ ] Backports are identified and tagged with Mergifyio. (cherry picked from commit f8ebe5f) # Conflicts: # riotfile.py # tox.ini
10 tasks
brettlangdon
previously approved these changes
Oct 26, 2022
Yun-Kim
previously approved these changes
Oct 26, 2022
|
@mergify[bot] this pull request is now in conflict 😩 |
Codecov Report
@@ Coverage Diff @@
## 0.61 #4379 +/- ##
=======================================
Coverage ? 78.66%
=======================================
Files ? 663
Lines ? 48475
Branches ? 0
=======================================
Hits ? 38133
Misses ? 10342
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mabdinur
reviewed
Nov 4, 2022
mabdinur
approved these changes
Nov 4, 2022
Kyle-Verhoog
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #4375 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com