Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add retry to the run test step for circleci [backport 2.17] #11515

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 22, 2024

Backport 6916049 from #11368 to 2.17.

Some CircleCI tests are flaky, which causes merge queue times to be long if the PR gets ejected for flakes. This will hopefully help remedy this symptom. Flakes should still be recorded since the same test will fail on the same commit, it just won't be a hard blocker if a retry will make the test pass.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Co-authored-by: taegyunkim <taegyun.kim@datadoghq.com>
(cherry picked from commit 6916049)
@github-actions github-actions bot added changelog/no-changelog A changelog entry is not required for this PR. mergequeue-status: done labels Nov 22, 2024
@github-actions github-actions bot requested review from a team as code owners November 22, 2024 20:55
@erikayasuda erikayasuda reopened this Nov 22, 2024
Copy link
Contributor Author

CODEOWNERS have been resolved as:

.circleci/config.templ.yml                                              @DataDog/python-guild @DataDog/apm-core-python

@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: backport-11368-to-2.17
Commit report: da04374
Test service: dd-trace-py

✅ 0 Failed, 592 Passed, 694 Skipped, 18m 13.25s Total duration (17m 51.18s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Nov 22, 2024

Benchmarks

Benchmark execution time: 2024-11-22 21:41:10

Comparing candidate commit da04374 in PR branch backport-11368-to-2.17 with baseline commit 86001af in branch 2.17.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 388 metrics, 2 unstable metrics.

@erikayasuda erikayasuda enabled auto-merge (squash) November 22, 2024 22:31
@erikayasuda erikayasuda merged commit 475d911 into 2.17 Nov 22, 2024
553 checks passed
@erikayasuda erikayasuda deleted the backport-11368-to-2.17 branch November 22, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. mergequeue-status: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant