Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/envoyproxy: fix context propagation from envoy tracing #3144

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

e-n-0
Copy link
Member

@e-n-0 e-n-0 commented Feb 4, 2025

What does this PR do?

Fix the context propagation from the context injected by Envoy in its tracing capabilities.

The information about the context was set by envoy into the gRPC metadata. These metadata are now merged with the headers of the received request.

Motivation

The spans generated with an instrumented Envoy with APM didn't got correlated correctly with the spans generated by the service extensions.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@e-n-0 e-n-0 requested review from a team as code owners February 4, 2025 13:01
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Feb 4, 2025
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 4, 2025

Datadog Report

Branch report: flavien/envoy/fix-propagated-headers-apm-envoy
Commit report: da4ce3e
Test service: dd-trace-go

✅ 0 Failed, 5223 Passed, 72 Skipped, 2m 1.32s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Feb 4, 2025

Benchmarks

Benchmark execution time: 2025-02-04 13:25:22

Comparing candidate commit bbac29e in PR branch flavien/envoy/fix-propagated-headers-apm-envoy with baseline commit 998add0 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant