Skip to content

Commit

Permalink
.circleci/config.yml: vendor gnostic for k8s.io/client-go (#585)
Browse files Browse the repository at this point in the history
k8s.io/client-go has github.com/googleapis/gnostic as a dependency.
Recently, gnostic renamed some packages to be consistent with go style (google/gnostic#155)
This change breaks client-go, which will no longer build when clients are checked out with e.g. go get k8s.io/client-go/kubernetes.

This break in k8s.io/client-go is causing our CI to fail. This commit addresses the issue by checking out k8s.io/client-go manually and vendoring the last working version of gnostic in k8s.io/client-go/vendor.
  • Loading branch information
knusbaum authored Feb 5, 2020
1 parent 7704362 commit 9e24f39
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,16 @@ jobs:
https://github.com/go-redis/redis
contrib/go-redis/redis/vendor/github.com/go-redis/redis
- run:
name: Vendor github.com/googleapis/gnostic for k8s.io/client-go
# This step checks out k8s.io/client-go and vendors
# github.com/googleapis/gnostic to fix a breaking change made in
# gnostic. See kubernetes/client-go#741
# TODO(knusbaum): remove this once the breaking change is resolved or propagated
command: |
git clone https://github.com/kubernetes/client-go $GOPATH/src/k8s.io/client-go
git clone --branch v0.4.0 https://github.com/googleapis/gnostic $GOPATH/src/k8s.io/client-go/vendor/github.com/googleapis/gnostic
- run:
name: Fetching dependencies
command: |
Expand Down

0 comments on commit 9e24f39

Please sign in to comment.