Fix git parser on really big pack files (>2GB) #1413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharycmontoya
approved these changes
Apr 19, 2021
lucaspimentel
approved these changes
Apr 19, 2021
andrewlock
approved these changes
Apr 20, 2021
Co-authored-by: Andrew Lock <andrew.lock@datadoghq.com>
f75105a to
6f8e006
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue detected in very large pack files where the git metadata couldn't be loaded.
The problem was before we were loading the object size using only 2 bytes, the PR changes to multiple bytes.
The PR has been tested loading data from the linux kernel git repo.
@DataDog/apm-dotnet