Revert "ProcessExit event handler improvements" #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0aaa30e.
kevingosse
approved these changes
Apr 16, 2021
andrewlock
approved these changes
Apr 16, 2021
lucaspimentel
approved these changes
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1332
This PR is causing problems on
WebRequest20Tests.SubmitsTracestest.There is an edge case where a delegate gets subscribed while the ProcessExit delegate invocation list is already being executed. In that case the count variable will read the actual number (after the subscription) but the for loop executing the invocation list will have the previous value. Resulting in merging the last delegate to a delegate that will never be executed.