-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add symbols to MSI #1364
Add symbols to MSI #1364
Conversation
Those wix files are actually kept in sync with the PrepareRelease tool. |
For the dlls we install in the GAC, we should copy the PDBs into |
I've considered it, but I'm not sure we should. I don't really like putting additional files into System32, and it doesn't bring much (the symbols are still available in the Datadog folder, the developer just has to load them manually). Not to mention that the GAC is versioned and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See @colin-higgins's comment about the PrepareRelease
tool: #1364 (comment)
And regenerate the wxs files
I was wondering why nobody ever reformatted those files 😄 |
@@ -11,18 +11,36 @@ | |||
Source="$(var.TracerHomeDirectory)\net45\Datadog.Trace.AspNet.dll" | |||
KeyPath="yes" Checksum="yes" Assembly=".net"/> | |||
</Component> | |||
<Component Win64="$(var.Win64)"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we need additional logic...we don't want the pdb files to be added to this "Net45.GAC" file or the "Net461.GAC" file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ugh, good catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in fe760dd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM good stuff!
Include the PDB symbols to the installer