Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for trace analytics #92

Merged
merged 2 commits into from
May 1, 2019
Merged

Add support for trace analytics #92

merged 2 commits into from
May 1, 2019

Conversation

cgilmour
Copy link
Contributor

This refactors all the existing datadog-specific tags into a public header, in addition to adding special behavior for the analytics_event tag.

Note: support for DD_ANALYTICS_ENABLED and DD_<INTEGRATION>_ANALYTICS_ENABLED environment variables is not included because there are no integrations to enable it for. All cases will effectively be custom integrations and unaffected by those environment variables.

This refactors common but datadog-specific tags into its own header.
Also updated definition for metrics to be double instead of int.
Copy link

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall idea is fine, a question that may require another step to complete the PR.

src/span.cpp Show resolved Hide resolved
Copy link

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge it.

@cgilmour cgilmour merged commit abda3d3 into master May 1, 2019
@cgilmour
Copy link
Contributor Author

cgilmour commented May 1, 2019

Fixes #89.
Docs will be updated soon with examples.

@cgilmour cgilmour deleted the cgilmour/analytics-tag branch May 1, 2019 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants