-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates node-addon-api #79
Conversation
Potentially solves #82 |
Bump Node-API version to 6 change use of global constructor for DDWAFContext constructor to a thread safe solution
8b985cc
to
913b97f
Compare
This PR fixes the problems related with worker_threads and the waf. Added a test to check that it is working fine. Here is a very short explanation about why this solves the problem:
|
@simon-id , please add some tests when you have a way to reproduce the issue