Add delete_misses/delete_hits to memcache #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://github.com/memcached/memcached/blob/master/doc/protocol.txt, there is delete_* stats we could use to report to datadog.
| # network | ||
| # limit_maxbytes 32u Number of bytes this server is allowed to | ||
| # use for storage. |
There was a problem hiding this comment.
Only removing white spaces on those comments, If thats too much noise, I can add them back. Let me know.
|
Thanks a lot @arthurnn! |
remh
pushed a commit
that referenced
this pull request
May 5, 2014
Add delete_misses/delete_hits to memcache
|
great thanks.. I noticed travis was falling before too, so I didnt bother much about fixing it. But fell free to ping me of you need any help. |
arthurnn
added a commit
to arthurnn/dd-agent
that referenced
this pull request
May 5, 2014
arthurnn
added a commit
to arthurnn/dd-agent
that referenced
this pull request
May 5, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/memcached/memcached/blob/master/doc/protocol.txt,
there is delete_* stats we could use to report to datadog.
@remh , please help me out here. I am not sure if I am missing something, I cannot setup the environment to run the tests locally, and I couldn't find any page explaining how to do that. So I changed the code I thought would make sense.
The reason for this is, we need to display
delete_hitsanddelete_missesto datadog, and right now we dont have those stats, and the memcached protocol says it support them.Thoughts?