Removed deprecated certificate for windows build #3886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove the `datadog-cert.pem` present in `install_files` for win32 install * update the ca-certificates.crt to removed deprecated certs.
truthbk
approved these changes
May 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please remember to review the Datadog Contribution Guidelines
if you have not yet done so.
What does this PR do?
datadog-cert.pempresent ininstall_filesfor win32 installca-certificates.crtto update and removed deprecated certs. now it use theca-certificates.crtfile from ubuntu.19.10Motivation
On old dd-agent version, the
ca-certificates.crtis used. This file was necessary for the "Tornado" dependency <3.0.0.the only place we I can see we use a fixed version of tornado is here: 9769656 that correspond to "dd-agent"
5.0.0releasewe stopped using the
ca-certificates.crtwith version5.12.x, since we don't use anymore the functionset_win32_cert_path()Testing Guidelines
An overview on testing
is available in our contribution guidelines.
Additional Notes
Anything else we should know when reviewing?