Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[alpine] fix source install dep resolution: bump pip #3825

Merged
merged 1 commit into from
Feb 27, 2019
Merged

Conversation

truthbk
Copy link
Member

@truthbk truthbk commented Feb 27, 2019

Note: Please remember to review the Datadog Contribution Guidelines
if you have not yet done so.

What does this PR do?

Fixes the source install. After a new release of isort (pulled in by pylint) an issue with the dependency resolution of the old pip we used to use was uncovered with transitive dependencies. This PR bumps the pip version to a more current release.

On a different note, it's debatable the pylint dependency belongs in the requirements, but let's address the root cause here - the outdated pip.

Motivation

Broken alpine build, source installs.

Testing Guidelines

An overview on testing
is available in our contribution guidelines.

Additional Notes

Change fixes the source install.

@truthbk truthbk merged commit 1d986d4 into master Feb 27, 2019
@truthbk truthbk added this to the 5.32.0 milestone Feb 27, 2019
@truthbk truthbk deleted the jaime/fixsource branch February 27, 2019 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants