[pyyaml] allow patching of unsafe pyyaml operations #3808
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please remember to review the Datadog Contribution Guidelines
if you have not yet done so.
What does this PR do?
Given the state of
pyyaml
package and the CVE-2017-18342 (which does not affect us), let's just make things a little safer for users who may be usingpyyaml
in their custom checks. This PR monkey patches unsafe operations, and points to the safe counterparts.Motivation
Make custom checks safer if they use
pyyaml
.Testing Guidelines
An overview on testing
is available in our contribution guidelines.
Additional Notes
We should make this very clear in the changelog.