Fix issue with creating tags from conf in IIS #3635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hush-hush
requested changes
Jan 12, 2018
checks/libs/win/pdhbasecheck.py
Outdated
| @@ -33,7 +33,7 @@ def __init__(self, name, init_config, agentConfig, instances, counter_list): | |||
|
|
|||
| cfg_tags = instance.get('tags') | |||
| if cfg_tags is not None: | |||
| tags = cfg_tags.join(",") | |||
| tags = (",").join(cfg_tags) | |||
There was a problem hiding this comment.
parentheses are not necessary:
",".join(cfg_tags)
hush-hush
approved these changes
Jan 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please remember to review the Datadog Contribution Guidelines
if you have not yet done so.
What does this PR do?
Fixes an issue when pulling tags from a yaml config file with any integration that uses the
PDHBaseCheckclassMotivation
A customer reached out with a report of the IIS check, which now collects metric via PDH, failing after upgrading to 5.21
Testing Guidelines
An overview on testing
is available in our contribution guidelines.
Additional Notes
Anything else we should know when reviewing?