Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sd][docker] no self log attribute, use global. #3314

Merged
merged 1 commit into from
Apr 20, 2017
Merged

[sd][docker] no self log attribute, use global. #3314

merged 1 commit into from
Apr 20, 2017

Conversation

truthbk
Copy link
Member

@truthbk truthbk commented Apr 20, 2017

What does this PR do?

Fixes a bug in the logging if the kubelet is not found.

Motivation

Found issue while testing.

olivielpeau
olivielpeau approved these changes Apr 20, 2017
View reviewed changes
Copy link
Member

@olivielpeau olivielpeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@truthbk truthbk merged commit a595b5e into master Apr 20, 2017
@truthbk truthbk deleted the jaime/kubefix branch April 20, 2017 19:42
@truthbk truthbk added this to the 5.13.0 milestone Apr 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivielpeau olivielpeau olivielpeau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@truthbk @olivielpeau