[kubernetes] - Do not check for kubernetes auth token secret if we have TLS certs configured #3221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xvello
added a commit
that referenced
this pull request
Jul 4, 2017
|
Hello @chen-anders, This commit 8711e64 from #3401 should fix your use case and remove the log. Can you please confirm you are happy with this and we can close your PR once this is merged into master? Regards |
|
Works for me. Thanks @xvello |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes it so we don't check for the kubernetes auth_token if TLS certs are already provided for authentication to the kube-apiserver (when the dd-agent is running on the host). The pre-existing dd-agent should work, but would log noisy "Token not found at /var/run/secrets/kubernetes.io/serviceaccount/token" errors to the logs.
Motivation
What inspired you to submit this pull request? Less noisy logs :)