[yarn] Add configurable application tags #3041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added application tags in the configuration file, allowing set extra tags for app metrics like queue, user, etc. Also, added the tags functionality merged in #2473 on tests
Change config, hopefully with more documentation.
4582224 to
bdbbf49
Compare
olivielpeau
approved these changes
Dec 5, 2016
| # application_tags: | ||
| # # tag_prefix: yarn_key | ||
| # - app_queue: queue |
There was a problem hiding this comment.
this example defines a list of dicts, not a dict, let's fix it
Risk of context spam.
bdbbf49 to
0358b58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased #2489 (and fixed typo).
Added application tags in the configuration file,
allowing set extra tags for app metrics like queue,
user, etc.
Also, added the tags functionality merged in
#2473
on tests