Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Cast system settings proxy port to int #1416

Merged
merged 1 commit into from
Mar 9, 2015
Merged

[core] Cast system settings proxy port to int #1416

merged 1 commit into from
Mar 9, 2015

Conversation

yannmh
Copy link
Member

@yannmh yannmh commented Mar 9, 2015

Fixes #1414

From http://tornado.readthedocs.org/en/latest/httpclient.html:

`proxy_host` (string) – HTTP proxy hostname. To use proxies, proxy_host and proxy_port must be set; proxy_username and proxy_pass are optional. Proxies are currently only supported with curl_httpclient.
`proxy_port` (int) – HTTP proxy port

@yannmh yannmh self-assigned this Mar 9, 2015
@yannmh yannmh added this to the 5.3.0 milestone Mar 9, 2015
@LeoCavaille
Copy link
Member

👍 Nice, waiting for the CI to complete but LGTM

LeoCavaille added a commit that referenced this pull request Mar 9, 2015
@LeoCavaille
Merge pull request #1416 from DataDog/yann/proxy-port-cast-fix
67ca5ac 
[core] Cast system settings proxy port to int
@LeoCavaille LeoCavaille merged commit 67ca5ac into master Mar 9, 2015
@LeoCavaille LeoCavaille deleted the yann/proxy-port-cast-fix branch March 9, 2015 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yannmh yannmh

Labels
bugfix core
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.

System Proxy Settings return a string instead of an integer for port
2 participants
@yannmh @LeoCavaille