disable mesos_task and chronos_job tags because of high cardinality

Kept them commented out with a message to explain why
DataDog · Jul 6, 2017 · 80aab0b · 80aab0b
1 parent f3182f2
commit 80aab0b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/tests/core/test_mesosutil.py b/tests/core/test_mesosutil.py
@@ -22,8 +22,9 @@ def test_extract_tags(self, mock_init):
                "MARATHON_APP_ID=/system/dd-agent",
                "MESOS_TASK_ID=system_dd-agent.dcc75b42-4b87-11e7-9a62-70b3d5800001"]
 
-        tags = ['chronos_job:test-job', 'marathon_app:/system/dd-agent',
-                'mesos_task:system_dd-agent.dcc75b42-4b87-11e7-9a62-70b3d5800001']
+        tags = ['marathon_app:/system/dd-agent']
+        ## Removed 'chronos_job:test-job', 'mesos_task:system_dd-agent.dcc75b42-4b87-11e7-9a62-70b3d5800001'
+        ## because of high cardinality
 
         container = {'Config': {'Env': env}}
 

diff --git a/utils/orchestrator/mesosutil.py b/utils/orchestrator/mesosutil.py
@@ -31,12 +31,13 @@ def _get_cacheable_tags(self, cid, co=None):
         envvars = co.get('Config', {}).get('Env', {})
 
         for var in envvars:
-            if var.startswith(CHRONOS_JOB_NAME):
-                tags.append('chronos_job:%s' % var[len(CHRONOS_JOB_NAME) + 1:])
-            elif var.startswith(MARATHON_APP_ID):
+            if var.startswith(MARATHON_APP_ID):
                 tags.append('marathon_app:%s' % var[len(MARATHON_APP_ID) + 1:])
-            elif var.startswith(MESOS_TASK_ID):
-                tags.append('mesos_task:%s' % var[len(MESOS_TASK_ID) + 1:])
+            ## Disabled for now because of high cardinality (~container card.)
+            #elif var.startswith(CHRONOS_JOB_NAME):
+            #    tags.append('chronos_job:%s' % var[len(CHRONOS_JOB_NAME) + 1:])
+            #elif var.startswith(MESOS_TASK_ID):
+            #    tags.append('mesos_task:%s' % var[len(MESOS_TASK_ID) + 1:])
 
         return tags