Db/agent5 apm resources #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivielpeau
approved these changes
Oct 31, 2017
olivielpeau
pushed a commit
that referenced
this pull request
Nov 1, 2017
* Add windows build flag to include windows build resources * Add registration of event viewer message file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds in call to build with event log message file and windows resources.
First change is to change build command to
"rake build windres=true". Windres=true tells the trace agent to build with windows resources (it doesn't by default in case that part of the toolchain isn't present, for instance when cross-compiling on linux).Second change in the install script registers the trace agent binary as the
log sourcefor event viewer; tells event viewer where to get the log strings from.