[SDTEST-744] add memory leaks tests with ruby_memcheck #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #246 +/- ##
=======================================
Coverage 98.86% 98.86%
=======================================
Files 279 279
Lines 13603 13603
Branches 637 637
=======================================
Hits 13449 13449
Misses 154 154 ☔ View full report in Codecov by Sentry. |
ivoanjo
approved these changes
Oct 8, 2024
| bundler-cache: true # runs 'bundle install' and caches installed gems automatically | ||
| bundler: latest | ||
| cache-version: v1 # bump this to invalidate cache | ||
| - run: sudo apt install -y valgrind && valgrind --version |
There was a problem hiding this comment.
You may want to borrow some of the tweaks we've done since to avoid flakiness in installing valgrind: https://github.com/DataDog/dd-trace-rb/blob/master/.github/workflows/test-memory-leaks.yaml#L14
Comment on lines
+37
to
+53
| # We don't care about the pkg-config external tool | ||
| { | ||
| pkg-config-memory | ||
| Memcheck:Leak | ||
| ... | ||
| obj:/usr/bin/pkg-config | ||
| ... | ||
| } | ||
|
|
||
| # We don't care about the tr external tool | ||
| { | ||
| pkg-config-memory | ||
| Memcheck:Leak | ||
| ... | ||
| obj:/usr/bin/tr | ||
| ... | ||
| } |
There was a problem hiding this comment.
I suspect you won't need these, but also they're harmless to keep, if you want to just keep this file mostly in sync with dd-trace-rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds https://github.com/Shopify/ruby_memcheck gem to automatically find and report memory leaks using valgrind. This PR mostly copies the setup from dd-trace-rb which was done in DataDog/dd-trace-rb#3852
Motivation
Prevent memory leaks from the native extension
How to test the change?
Github Actions workflow is added