Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags and description to logs pipelines #2208

Merged

Conversation

@@ -120,6 +134,12 @@ def initialize(attributes = {})
end
end

if attributes.key?(:'tags')
if (value = attributes[:'tags']).is_a?(Array)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Quality Violation

Consider using Array() to ensure the type is that of an array (...read more)

The rule "Use Array() to ensure your variable is an array" is important for ensuring your code behaves as expected, regardless of the type of data it receives. It is common in Ruby to need to iterate through an array of items. However, if the variable is not an array, this can lead to unexpected behavior or errors.

The Array() method in Ruby is a Kernel method that converts its argument to an Array. If the argument is already an Array, it returns the argument. If the argument is nil, it returns an empty Array. This can be used to ensure that a variable is an array before trying to iterate over it, preventing potential errors or unexpected behavior.

By using Array(foos), you can ensure that foos is an array before you try to iterate over it with each. This prevents the need to check if foos is an array with foos.is_a?(Array) and makes your code cleaner and easier to understand.

View in Datadog  Leave us feedback  Documentation

@datadog-datadog-prod-us1
Copy link

Datadog Report

Branch report: datadog-api-spec/generated/3491
Commit report: 56905ba
Test service: datadog-api-client-ruby

✅ 0 Failed, 2805 Passed, 81 Skipped, 2m 39.48s Total Time

@api-clients-generation-pipeline api-clients-generation-pipeline bot merged commit 4da316b into master Jan 23, 2025
18 of 19 checks passed
@api-clients-generation-pipeline api-clients-generation-pipeline bot deleted the datadog-api-spec/generated/3491 branch January 23, 2025 22:18
github-actions bot pushed a commit that referenced this pull request Jan 23, 2025
Co-authored-by: ci.datadog-api-spec <packages@datadoghq.com> 4da316b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant