Add metric_namespace_configs to GCP v2 API #2248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "id": "id", | ||
| } | ||
|
|
||
| def __init__(self_, disabled: Union[bool, UnsetType] = unset, id: Union[str, UnsetType] = unset, **kwargs): |
There was a problem hiding this comment.
🔴 Code Quality Violation
Suggested change
| def __init__(self_, disabled: Union[bool, UnsetType] = unset, id: Union[str, UnsetType] = unset, **kwargs): | |
| def __init__(self, disabled: Union[bool, UnsetType] = unset, id: Union[str, UnsetType] = unset, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self by convention.
Learn More
a0ed8e1 to
d1d8d69
Compare
jack-edmonds-dd
approved these changes
Nov 5, 2024
d79ff13 to
391a17c
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Nov 6, 2024
* Regenerate client from commit 2db17c21 of spec repo * pre-commit fixes --------- Co-authored-by: ci.datadog-api-spec <packages@datadoghq.com> 00824e6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See DataDog/datadog-api-spec#3280
Test branch datadog-api-spec/test/ashraf.hanafy/gcpi/add-metric-namespace-configs