Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when closing an async client. #2186

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

jack-edmonds-dd
Copy link
Contributor

Fixes #2139

What does this PR do?

Additional Notes

Review checklist

Please check relevant items below:

  • This PR includes all newly recorded cassettes for any modified tests.

  • This PR does not rely on API client schema changes.

    • The CI should be fully passing.
  • Or, this PR relies on API schema changes and this is a Draft PR to include tests for that new functionality.

    • Note: CI shouldn't be run on this Draft PR, as its expected to fail without the corresponding schema changes.

@jack-edmonds-dd jack-edmonds-dd requested a review from a team as a code owner September 30, 2024 18:57
@jack-edmonds-dd jack-edmonds-dd merged commit df7db0d into master Sep 30, 2024
15 of 16 checks passed
@jack-edmonds-dd jack-edmonds-dd deleted the jack-edmonds-dd/APITL-1144 branch September 30, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't close AsyncApiClient
2 participants